Fix/mlwmsloader layer switch #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes layer switching functionality in the MlWmsLoader component and refactors the sortable container implementation.
Changes:
- Modified SortableContainer to use dynamic UUIDs instead of layer IDs for drag-and-drop functionality
- Enhanced MlWmsLoader with new props for controlling layer visibility, feature info callbacks, and UI display
- Updated MlWmsLayer to simplify layer initialization and improve source change detection
- Upgraded maplibre-gl dependency and updated test assertions to use newer API methods
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SortableContainer.tsx | Removed layerId prop and switched to UUID-based IDs for sortable items |
| LayerListItem.tsx | Updated to pass children without layerId prop to SortableContainer |
| MlWmsLoader.tsx | Added visibility control, feature info callbacks, and conditional layer list rendering |
| MlWmsLayer.tsx | Simplified layer initialization logic and improved source update detection |
| MlTerrainLayer.cy.tsx | Updated test assertions from sourceCaches to getSource API |
| package.json | Upgraded maplibre-gl from 5.7.0 to 5.16.0 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-maplibre/src/ui_components/LayerList/util/SortableContainer.tsx
Outdated
Show resolved
Hide resolved
packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.